Skip to content

Do not capture continuation on netty GlobalEventExecutor static init#11654

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
andrea.marziali/netty-startup
Jun 16, 2026
Merged

Do not capture continuation on netty GlobalEventExecutor static init#11654
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
andrea.marziali/netty-startup

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

Disable the async propagation when netty's GlobalEventExecutor class initialises. It's a lazily built singleton whose constructor schedules a long-lived housekeeping task. Capturing a continuation on that task pins whatever trace is active at first-touch open forever.

Motivation

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added type: enhancement Enhancements and improvements inst: netty Netty instrumentation labels Jun 16, 2026
@datadog-prod-us1-5

This comment has been minimized.

@amarziali

amarziali commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d0acc42bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dd-octo-sts

dd-octo-sts Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.94 s 13.95 s [-0.8%; +0.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.90 s 12.93 s [-0.8%; +0.4%] (no difference)
startup:petclinic:appsec:Agent 16.91 s 16.59 s [+0.8%; +3.1%] (maybe worse)
startup:petclinic:iast:Agent 16.83 s 16.90 s [-1.0%; +0.2%] (no difference)
startup:petclinic:profiling:Agent 16.32 s 16.88 s [-7.7%; +1.1%] (no difference)
startup:petclinic:sca:Agent 16.87 s 16.69 s [+0.1%; +2.1%] (maybe worse)
startup:petclinic:tracing:Agent 16.02 s 16.08 s [-1.4%; +0.7%] (no difference)

Commit: 5b415f9d · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@amarziali amarziali marked this pull request as ready for review June 16, 2026 11:02
@amarziali amarziali requested review from a team as code owners June 16, 2026 11:02
@amarziali amarziali requested review from bric3, mcculls and ygree and removed request for a team June 16, 2026 11:02
@amarziali

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 16, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-16 12:54:06 UTC ℹ️ Start processing command /merge


2026-06-16 12:54:12 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-06-16 14:14:15 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 1b4d0ee into master Jun 16, 2026
581 of 584 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/netty-startup branch June 16, 2026 14:14
@github-actions github-actions Bot added this to the 1.64.0 milestone Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: netty Netty instrumentation type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants