fix: remove deprecated admin-role detection and fix settings 403#1324
Open
Aryan-Verma-999 wants to merge 2 commits into
Open
fix: remove deprecated admin-role detection and fix settings 403#1324Aryan-Verma-999 wants to merge 2 commits into
Aryan-Verma-999 wants to merge 2 commits into
Conversation
Aryan-Verma-999
force-pushed
the
fix/remove-admin-role-detection
branch
from
09ba04e to
c886439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove deprecated admin-role detection and fix settings 403
Acceptance Criteria fulfillment
/v1/settings.public?_id=Message_MaxAllowedSizeto resolve the 403 error on settings fetch.PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1324 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.