Make theme store context test deterministic#7806
Open
alfonso-noriega wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
no-changelog
alfonso-noriega
force-pushed
the
make-theme-store-context-test-deterministic
branch
from
f1f0fb3 to
ba96643
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces fixed timeout sleeps in the theme store context test with explicit promise synchronization.
Why
This is preventive test cleanup: I did not find historical failures for this exact test in recent failed runs, but the test was asserting async context isolation with timing-based sleeps. Explicit synchronization keeps the same coverage without depending on fixed delays.
Testing
pnpm vitest run packages/theme/src/cli/services/local-storage.test.ts