Make E2E config link non-interactive#7809
Closed
alfonso-noriega wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Makes the E2E
app config linkhelper run non-interactively when creating the secondary app inapp-deploy.spec.ts.app config link --new-app-namesupport for tests/automation.cli.exec()with--organization-idand--new-app-nameinstead of driving Ink prompts through PTY timing sleeps.Why
PR #7803 exposed a separate flake:
app config linkcould receive Enter before Ink had consumed/rendered typed prompt input, causing the org selector or app-name prompt to submit stale state. In the failing run the prompt visibly showed the secondary app name, but validation still reportedApp name can't be empty, and the process eventually timed out.This removes that timing-sensitive prompt automation from the E2E path.
Testing
pnpm --filter @shopify/app vitest src/cli/services/dev/select-app.test.ts src/cli/services/app/config/link.test.ts --runpnpm --filter @shopify/app lintpnpm --filter e2e lintAttempted, but blocked by existing
cli-kit:buildmissing GraphiQL dependency errors (h3,react-dom/server,@shopify/polaris,@shopify/polaris-icons):pnpm --filter @shopify/app type-checkpnpm --filter e2e type-check