Theme: forward ThemeProvider cornerRadius preset to :root for root providers#79153
Open
ciampo wants to merge 3 commits into
Open
Theme: forward ThemeProvider cornerRadius preset to :root for root providers#79153ciampo wants to merge 3 commits into
ciampo wants to merge 3 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Restore the `:root:has([data-wpds-root-provider="true"][data-wpds-corner-radius="…"])` selectors for each corner-radius preset mode in the Terrazzo config (and the generated prebuilt CSS) so a root `ThemeProvider` applies the `--wpds-border-radius-*` tokens to the document element, consistent with how `color` and `cursor` tokens already behave. Follow-up to #78816 (comment)
ciampo
force-pushed
the
add-corner-radius-root-selector
branch
from
3108de9 to
93a39d0
Compare
|
Size Change: +36 B (0%) Total Size: 8.59 MB 📦 View Changed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #78816 (review thread).
What
A root
ThemeProvider(isRoot) now forwards itscornerRadiuspreset to the document element, so--wpds-border-radius-*applies to<html>— not just the provider's scoping<div>. This matches howcolorandcursoralready behave.Why
color/cursorfrom a root provider already cascade to:root;cornerRadiuswas the odd one out. Mixed pages (React UI + PHP-rendered admin HTML) consume the tokens outside the React root, so the radius preset should reach<html>too.Only
isRootproviders are affected — non-root nested providers still scope their preset locally.How
Each
corner-radius-*mode interrazzo.config.tsgains a:root:has([data-wpds-root-provider="true"][data-wpds-corner-radius="…"])selector (plus regenerated CSS + CHANGELOG).Test plan
ThemeProviderand switch the preset; confirm--wpds-border-radius-*updates on:rootin DevTools.:root.color/cursorroot forwarding still works and the default (subtle) preset matches existing appearance.Note on the generated CSS
src/prebuilt/css/design-tokens.cssis regenerated bynpm run build(inpackages/theme); running the full build produces this exact diff with no other changes.Use of AI
Made with Cursor.