Skip to content

build: update dependency esbuild-wasm to v0.28.1 (22.0.x)#33385

Merged
alan-agius4 merged 1 commit into
angular:22.0.xfrom
angular-robot:ng-renovate/22.0.x-esbuild-wasm-0-x
Jun 16, 2026
Merged

build: update dependency esbuild-wasm to v0.28.1 (22.0.x)#33385
alan-agius4 merged 1 commit into
angular:22.0.xfrom
angular-robot:ng-renovate/22.0.x-esbuild-wasm-0-x

Conversation

@angular-robot

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
esbuild-wasm 0.28.00.28.1 age adoption passing confidence

  • If you want to rebase/retry this PR, check this box

Release Notes

evanw/esbuild (esbuild-wasm)

v0.28.1

Compare Source

  • Disallow \ in local development server HTTP requests (GHSA-g7r4-m6w7-qqqr)

    This release fixes a security issue where HTTP requests to esbuild's local development server could traverse outside of the serve directory on Windows using a \ backslash character. It happened due to the use of Go's path.Clean() function, which only handles Unix-style / characters. HTTP requests with paths containing \ are no longer allowed.

    Thanks to @​dellalibera for reporting this issue.

  • Add integrity checks to the Deno API (GHSA-gv7w-rqvm-qjhr)

    The previous release of esbuild added integrity checks to esbuild's npm install script. This release also adds integrity checks to esbuild's Deno install script. Now esbuild's Deno API will also fail with an error if the downloaded esbuild binary contains something other than the expected content.

    Note that esbuild's Deno API installs from registry.npmjs.org by default, but allows the NPM_CONFIG_REGISTRY environment variable to override this with a custom package registry. This change means that the esbuild executable served by NPM_CONFIG_REGISTRY must now match the expected content.

    Thanks to @​sondt99 for reporting this issue.

  • Avoid inlining using and await using declarations (#​4482)

    Previously esbuild's minifier sometimes incorrectly inlined using and await using declarations into subsequent uses of that declaration, which then fails to dispose of the resource correctly. This bug happened because inlining was done for let and const declarations by avoiding doing it for var declarations, which no longer worked when more declaration types were added. Here's an example:

    // Original code
    {
      using x = new Resource()
      x.activate()
    }
    
    // Old output (with --minify)
    new Resource().activate();
    
    // New output (with --minify)
    {using e=new Resource;e.activate()}
  • Fix module evaluation when an error is thrown (#​4461, #​4467)

    If an error is thrown during module evaluation, esbuild previously didn't preserve the state of the module for subsequent module references. This was observable if import() or require() is used to import a module multiple times. The thrown error is supposed to be thrown by every call to import() or require(), not just the first. With this release, esbuild will now throw the same error every time you call import() or require() on a module that throws during its evaluation.

  • Fix some edge cases around the new operator (#​4477)

    Previously esbuild incorrectly printed certain edge cases involving complex expressions inside the target of a new expression (specifically an optional chain and/or a tagged template literal). The generated code for the new target was not correctly wrapped with parentheses, and either contained a syntax error or had different semantics. These edge cases have been fixed so that they now correctly wrap the new target in parentheses. Here is an example of some affected code:

    // Original code
    new (foo()`bar`)()
    new (foo()?.bar)()
    
    // Old output
    new foo()`bar`();
    new (foo())?.bar();
    
    // New output
    new (foo())`bar`();
    new (foo()?.bar)();
  • Fix renaming of nested var declarations (#​4471)

    This release fixes a bug where var declarations in nested scopes that are hoisted up to module scope were not correctly being renamed during bundling. That could previously lead to name collisions when minification was disabled, which could potentially cause a behavior change. The bug has been fixed so that these hoisted declarations are now considered to be module-level symbols during the name collision avoidance pass.

  • Emit var instead of const for certain TypeScript-only constructs for ES5 (#​4448)

    While esbuild doesn't generally support converting const to var for ES5 due to nested scoping rules (which is currently a build-time error), esbuild previously incorrectly converted TypeScript-only import assignment constructs into a const declaration even when targeting ES5. With this release, esbuild will now use var for this case instead:

    // Original code
    import x = require('y')
    
    // Old output (with --target=es5)
    const x = require("y");
    
    // New output (with --target=es5)
    var x = require("y");

@angular-robot angular-robot added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] labels Jun 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the esbuild-wasm dependency to version 0.28.1 in both the root package.json and packages/angular_devkit/build_angular/package.json. However, the reviewer noted that esbuild was not updated to match, creating a version mismatch. This mismatch can lead to inconsistent build behaviors or leave security vulnerabilities (such as GHSA-g7r4-m6w7-qqqr) unpatched depending on the platform runner used. It is recommended to update esbuild to 0.28.1 in both files to maintain consistency.

Comment thread package.json
"buffer": "6.0.3",
"esbuild": "0.28.0",
"esbuild-wasm": "0.28.0",
"esbuild-wasm": "0.28.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating esbuild-wasm to 0.28.1 without updating esbuild to 0.28.1 introduces a version mismatch. Since the build system dynamically selects between the native esbuild binary and the WASM fallback (esbuild-wasm) depending on platform support, this mismatch can lead to inconsistent build behavior or unpatched security vulnerabilities (such as the Windows path traversal vulnerability GHSA-g7r4-m6w7-qqqr) depending on which runner is executed. Please update esbuild to 0.28.1 as well.

"copy-webpack-plugin": "14.0.0",
"css-loader": "7.1.4",
"esbuild-wasm": "0.28.0",
"esbuild-wasm": "0.28.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating esbuild-wasm to 0.28.1 without updating the optional dependency esbuild to 0.28.1 introduces a version mismatch. To prevent inconsistent build behavior or security vulnerabilities depending on whether the native or WASM runner is executed, please update optionalDependencies.esbuild to 0.28.1 as well.

See associated pull request for more information.
@angular-robot angular-robot force-pushed the ng-renovate/22.0.x-esbuild-wasm-0-x branch from f76b6f5 to d7c9d77 Compare June 16, 2026 11:05
@alan-agius4 alan-agius4 merged commit d3e8951 into angular:22.0.x Jun 16, 2026
34 checks passed
@alan-agius4 alan-agius4 deleted the ng-renovate/22.0.x-esbuild-wasm-0-x branch June 16, 2026 11:31
@alan-agius4

Copy link
Copy Markdown
Collaborator

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants