Skip to content

Fix declaration of _lock, take 2#132

Merged
DerThorsten merged 1 commit into
emscripten-forge:mainfrom
ianthomas23:lock-fix-2
Jun 17, 2026
Merged

Fix declaration of _lock, take 2#132
DerThorsten merged 1 commit into
emscripten-forge:mainfrom
ianthomas23:lock-fix-2

Conversation

@ianthomas23

Copy link
Copy Markdown
Contributor

My fix in PR #130 was wrong, although it fixed the xeus-runner problem it broke use of pyjs in emscripten-forge recipe tests. Here is the correct fix.

I've tested it locally as follows:

  1. Rebuild pyjs on emscripten-forge with this patch.
  2. Rebuild xeus-python on emscripten-forge using the new pyjs.
  3. Rebuild xeus-pywrap on emscripten-forge using the new pyjs.
  4. Now rebuilding any python package on emscripten-forge, such as contourpy, the tests pass whereas before the patch they failed with an error about the _lock.
  5. Build a local jupyterlite deployment using these packages, python code such as matplotlib interactive plots run as expected without error.
  6. Python and shakespearelang kernels run correctly in xeus-runner still.

@DerThorsten DerThorsten merged commit 79e2505 into emscripten-forge:main Jun 17, 2026
1 check passed
@ianthomas23 ianthomas23 deleted the lock-fix-2 branch June 17, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants