chore(bigquery-jdbc): refactor tests to remove hardcoded base uri#13420
chore(bigquery-jdbc): refactor tests to remove hardcoded base uri#13420logachev wants to merge 7 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a helper method getBaseConnectionUrl() in TestUtilities to centralize and parameterize the base JDBC connection URL, and updates various integration tests to use this method instead of hardcoded strings. The review identified several critical compilation errors related to string concatenation and syntax in the updated test files, as well as minor cleanup opportunities for redundant string concatenations.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the integration tests to dynamically construct the BigQuery JDBC connection URL using environment variables or system properties, replacing hardcoded URL strings across multiple test classes. Feedback suggests improving the robustness of the URL flag parsing in TestUtilities, declaring the shared connectionUrl in ITBase as final to ensure immutability, and avoiding redundant caching of the connection URL in local class fields across several test files by referencing ITBase.connectionUrl directly.
1 participant
No description provided.