fix(auth): Fix UserCredentials serialization clientSecret leak#13465
Open
lsirac wants to merge 3 commits into
Open
fix(auth): Fix UserCredentials serialization clientSecret leak#13465lsirac wants to merge 3 commits into
lsirac wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in UserCredentials.java where the quotaProjectId was incorrectly serialized as quota_project with the value of clientSecret. It is now correctly serialized as quota_project_id with the value of quotaProjectId. Additionally, the @test annotation was added to a test in DefaultCredentialsProviderTest.java, and test coverage was updated in UserCredentialsTest.java to verify that the quota project ID is correctly saved and restored. There are no review comments, and I have no additional feedback to provide.
lsirac
force-pushed
the
fix-usercredentials-sec-leak
branch
from
8a9ccdf to
a1cbd31
Compare
macastelaz
approved these changes
Jun 15, 2026
lqiu96
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical security issue where the plaintext clientSecret of UserCredentials was being leaked and written to disk under the key quota_project, instead of the actual quotaProjectId under quota_project_id.