fix: helper function that determines the ion-menu animation side now …#31214
Open
Austin-Spriggs wants to merge 1 commit into
Open
fix: helper function that determines the ion-menu animation side now …#31214Austin-Spriggs wants to merge 1 commit into
Austin-Spriggs wants to merge 1 commit into
Conversation
…takes parent element direction attribute into consideration
|
@Austin-Spriggs is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: helper function that determines the ion-menu animation side now takes parent element direction attribute into consideration
Issue number: resolves #30226
What is the current behavior?
Hamburger menu is not animating from right to left when within an ion-app component with attribute dir="rtl".
What is the new behavior?
I modified the helper function that determines which side the animation is played from so that the direction attribute of the menu's parent elements can be determined before setting the animation direction.
Does this introduce a breaking change?