yaml: set sandbox router namespace to default#933
Conversation
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
✅ Deploy Preview for agent-sandbox canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ningmingxiao The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @ningmingxiao! |
|
Hi @ningmingxiao. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Python sandbox-router Kubernetes manifest to explicitly set metadata.namespace: default for the Service and Deployment. The intent (per PR description) is to prevent the router from being created in whatever namespace the user has set as their current context.
Changes:
- Set
metadata.namespace: defaulton theServiceinsandbox_router.yaml. - Set
metadata.namespace: defaulton theDeploymentinsandbox_router.yaml.
| name: sandbox-router-svc | ||
| namespace: default |
| name: sandbox-router-deployment | ||
| namespace: default |
What this PR does / why we need it:
use doc:
https://github.com/kubernetes-sigs/agent-sandbox/blob/main/examples/quickstart/README.md#31-create-dedicated-namespacehttps://github.com/kubernetes-sigs/agent-sandbox/blob/main/examples/quickstart/README.md#31-create-dedicated-namespace
kubectl config set-context --current --namespace=agent-sandbox-demo
and then create sandbox_router.yaml will create at namespace agent-sandbox-demo.
Which issue(s) this PR is related to:
Release Note