Book capacity only for ProvisioningRequest without scheduled pods

[cvgenesis]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Expires booking once it founds that the all pods for the ProvisioningRequest are scheduled.

This solves a bug when bookCapacity reserves capacity for every pod of a Provisioned ProvisioningRequest, including pods already running in the cluster, for the full reservation window. This leads to duplicate capacity calculation so some other ProvisioningRequests remain with CapacityIsNotFound.

• Sets BookingExpired for PRs with all pods already scheduled
• Adds a new reason for BookingExpired - CapacityBookingConsumed
• Adds a test for the bug

Which issue(s) this PR fixes:

Fixes #9805

Special notes for your reviewer:

I tried to make the minial change, so I used BookingExpired. But maybe it makes sense to add a new condition. Or vice versa, to skip consumed PRs silently without booking - in this case it will be just a fix for a duplicated resource count without any externally visible changes.

Does this PR introduce a user-facing change?

• Adds a new reason for BookingExpired - CapacityBookingConsumed

Once all pods for the ProvisioningRequest are scheduled the ProvisioningRequest adds condition BookingExpired with the reason CapacityBookingConsumed

[k8s-ci-robot]

This issue is currently awaiting triage.

If SIG Autoscaling contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cvgenesis
Once this PR has been reviewed and has the lgtm label, please assign bigdarkclown for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @cvgenesis!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @cvgenesis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.