build: add QUIC CI job for PRs matching QUIC related paths#63875
Open
pimterry wants to merge 1 commit into
Open
build: add QUIC CI job for PRs matching QUIC related paths#63875pimterry wants to merge 1 commit into
pimterry wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
Member
Author
|
CC @nodejs/quic |
Member
|
At what point do we intend to take quic out from behind the build flag? |
Qard
approved these changes
Jun 13, 2026
Member
Author
Hard to say, but at the moment there's still quite a few very breaking API changes to come that are already visible, along with plenty of other work to do on the details. I'd lean towards keeping it behind the build flag for a bit longer, until that settles down somewhat. Obviously it doesn't need to be perfectly stable for an experimental runtime flag, but it's a bit inconvenient if the API breaks every other release. |
efekrskl
approved these changes
Jun 13, 2026
This notable includes stream/iter (since they're closely related and rapidly evolving together) and ngtcp2, nghttp3 & openssl deps. Based on test-linux.yml, the main differences are simplifications: PRs only, filtered to specific paths, just one build (ARM only), no unusual characters test. Signed-off-by: Tim Perry <pimterry@gmail.com>
bjohansebas
added
author ready
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/63875 ✔ Done loading data for nodejs/node/pull/63875 ----------------------------------- PR info ------------------------------------ Title build: add QUIC CI job for PRs matching QUIC related paths (#63875) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch pimterry:quic-ci-job -> nodejs:main Labels meta, author ready Commits 1 - build: add QUIC CI job for PRs matching QUIC related paths Committers 1 - Tim Perry <pimterry@gmail.com> PR-URL: https://github.com/nodejs/node/pull/63875 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63875 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 12 Jun 2026 11:24:54 GMT ✔ Approvals: 1 ✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/63875#pullrequestreview-4491276090 ✘ This PR needs to wait 115 more hours to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/27506119139 |
bjohansebas
removed
the
commit-queue-failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matching paths notably includes stream/iter (since they're closely related and rapidly evolving together) and ngtcp2, nghttp3 & openssl deps.
The config here is based primarily on test-linux.yml, the diffs are simplifications: PRs only to limit the disruption (don't run on branches & releases etc for now), filtered to specific paths, just one build (ARM only, like test-internet/test-shared), no unusual characters test.
This will fail until #63874 & #63821 are merged - that's expected, QUIC builds are currently broken on main.PRs now merged, this has been rebased and it's all passing 🥳I'm hoping all the tiny fixes there will go in pretty fast though, happy to discuss the CI job here separately and check the best setup approach for this while QUIC is still experimental. This is my first time touching any of Node CI so let me know if this isn't quite right somewhere.