receive: Active tenants not compacting due to wall clock check#8850
Draft
saswatamcode wants to merge 1 commit into
Draft
receive: Active tenants not compacting due to wall clock check#8850saswatamcode wants to merge 1 commit into
saswatamcode wants to merge 1 commit into
Conversation
Adds a test to capture scenario where an active tenant (after new rollout), wouldn't get compacted to due wall clock check in doIter (now tryCompactHead). Trying some fixes for it, will test on actual cluster monday. Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test to capture scenario where an active tenant (after new rollout), wouldn't get compacted until second tick due to wall clock check in doIter (now tryCompactHead).
Trying some fixes for it, will test on actual cluster monday to actually confirm the issue here, needs to be rolled out and tested over multiple hours.
TestPeriodicHeadCompaction passes but TestWallClockCompactionBug fails.
Changes
Verification