Avoid E2E teardown retries after browser closes#7803
Open
alfonso-noriega wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
no-changelog
alfonso-noriega
force-pushed
the
avoid-e2e-teardown-closed-page-retries
branch
from
e1ea7f7 to
004d6af
Compare
alfonso-noriega
force-pushed
the
avoid-e2e-teardown-closed-page-retries
branch
from
004d6af to
c57ef70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stops E2E app teardown from retrying after Playwright has already closed the browser page, and caps best-effort dashboard app deletion to a fixed teardown time budget.
Why
Recent failed runs show repeated teardown noise with the same browser-closed pattern:
Target page, context or browser has been closedapp deletion failed after 3 attemptsA related failure mode is the app deploy E2E completing its assertions but then consuming the remaining test timeout while trying to delete a secondary app from the Dev Dashboard. If dashboard cleanup cannot complete quickly, the per-test cleanup scripts can reap the orphan later.
Testing
pnpm --filter e2e lintpnpm --filter e2e type-checkattempted previously, but blocked by existingcli-kit:builderrors for missing GraphiQL dependencies (h3,react-dom/server,@shopify/polaris,@shopify/polaris-icons).